Web client http context lifecycle cleanup #2707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The web client implementation
HttpContexthas been designed when Vert.x was still using handler of async results. Since the update to using the future model mainstream the implementation although it has been updated to use futures has not been fully updated and the internal still use artificial promises to connect the flow between the various execution phases of the context.This rewrites partly the implementation of
HttpContextto remove un-necessary logic (e.g. the creation of intermediary promises) and simplify the implementation to make it easier to reason about the flow of execution phases.In addition the body codec SPI has been slightly simplified (transformed an un-necessary handler async result into a synchronous method.